fix: Modify Popup.svelte to accept slots to render header and footer …#384
Conversation
…properly without scrolling off the screen
|
May I ask what your Reasoning is to change this Behaviour? |
|
Yeah, the changes look OK, but you need to provide a longer description of the change |
|
Sorry for the low effort on the original description. I made it late at night and forgot to add the description. I've updated the original description for the PR. |
Could you please also add some before, after Pictures? |
|
Thanks, looks good! I'll look at this when I get back to OpenDeck stuff (who knows when) |
|
I cleaned up some classes/spacing, ensured there wasn't a huge gap below the header in PluginManager and SettingsView, and then reverted the changes for PluginDetails because it was looking pretty weird there (with an empty header title and with the README border getting cut off). Let me know if everything still looks good. |
|
Thanks |
Summary
This PR improves how popup windows are displayed across the app, especially in places like Settings, Plugins, Profile management, and Plugin details.
Previously, popup content could behave awkwardly when there was too much information on screen. Titles, close buttons, and footer content could scroll together with the rest of the popup, and in some cases footer text could overlap or sit on top of the main content.
With this change, popups have clearer sections: the top area stays reserved for the title and close button, the main content scrolls independently, and optional footer content stays separated from the scrollable area. This makes the popup layout more predictable and keeps important controls in a consistent place.
This does not add new user-facing features, but it improves the overall usability and polish of existing dialogs.
What Changed
Images
The settings one was taken with the inspector open to force the size to be able to see the difference.
Preflight checklist
If you remove this checklist, this pull request will be closed without explanation.